wrong help text for the trade_revenue_style server option

• 回報者: log65536
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Documentation
• 里程碑: 3.0.0 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

Attempting my first patch for Freeciv, a simple one to get used to the workflow. Please tell me if something is not in line with recommended practice and I'll do it better next time.

Ticket History (3/7 Histories)

2021-10-01 07:19 Updated by: log65536

• New Ticket "wrong help text for the trade_revenue_style server option" created

2021-10-01 07:19 Updated by: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is attached

2021-10-01 07:20 Updated by: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is deleted

2021-10-01 07:20 Updated by: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7572) is attached

2021-10-01 07:23 Updated by: log65536

• 元件 Update from (無) to Documentation

2021-10-01 08:39 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.0.0 (closed)

評語

Patch seems perfect to me.

Workflow note about what happens next: As osdn does not have a ticket state "In Testing" / "In Review", or anything like that, we use "Accepted" (which we have no other use for) to mark patch that has entered public review period, minimum of 36h. In this case we have the 3.0.0-beta3 release coming in a week, and as this 1) is not a regression since beta2 2) introduces translatable string change, we're unlikely to push it in last minute but rather wait until beta3 is out.

2021-10-09 01:36 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正