待辦事項 #42939

British isles startpos nations not available

啟用日期: 2021-09-28 17:05 最後更新: 2021-10-01 23:10

回報者:
負責人:
類型:
狀態:
關閉
元件:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

Reported by Molo_Parko in http://forum.freeciv.org/f/viewtopic.php?f=13&t=91988#p104022 . Of the nations that have startpos in british isles scenario, only English show up (other startpos get filled with random other nations). This is because those other nations are not in the "core" nationset, and the scenario uses it (as it's the default).

Ticket History (3/6 Histories)

2021-09-28 17:05 Updated by: cazfi
  • New Ticket "British isles startpos nations not available" created
2021-09-28 21:23 Updated by: cazfi
評語

Separate ticket opened about sanitychecking these kind of issues in general -> #42940

2021-09-28 22:33 Updated by: cazfi
評語

About the only sane thing to do is to set nationset to "all" in the scenario. There's no point in having the start positions defined for the nations if they are never used. We could remove the nation definitions from the start positions, but the idea of the British isles scenario is to have british isles with local nations, isn't it?

The problem with this is that supplied, official, scenarios shouldn't rely on "lower quality" (i.e. more likely to be missing) translations of the legends and nation names in the nations translation domain. That was the point of splitting translation domains and introducing whole nationset feature in the first place.

My proposal is: Set nationset "all" in the scenario, but because of the slight controversy related to translation domains, do not target this to mature S2_6, but only to S3_0 and later.

2021-09-28 22:46 Updated by: cazfi
評語

Patch attached. Set target to beta3, but we'll see if that holds.

2021-10-01 23:10 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入