dai_calc_data() income calculation does not include immediately spent part

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: AI
• 里程碑: 2.6.6 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

dai_calc_data() counts only 'surplus' as income, not including what's being immediately spent. Expenses are correctly calculated. So in perfect balance 'income' is returned as zero, and expenses as some high number. Callers then think that expenses > income.

Ticket History (3/9 Histories)

2021-05-07 18:47 Updated by: cazfi

• New Ticket "dai_calc_data() income calculation does not include immediately spent part" created

2021-05-07 22:40 Updated by: cazfi

• File 0053-AI-Consider-immediately-spent-gold-as-part-of-income.patch (File ID: 6728) is attached

2021-05-07 22:40 Updated by: cazfi

• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 2.6.5 (closed)

2021-05-07 22:46 Updated by: chippo

評語

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

2021-05-07 22:58 Updated by: cazfi

評語

Reply To chippo

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

There should be a slight improvement to overall AI performance, but you would need to apply statistical methods to see them - variations between individual games are bigger than effects of the bug fixed. With civ2civ3 #42191 might override any improved calculation correctness, so you would need to use e.g. classic ruleset.

2021-05-23 16:16 Updated by: cazfi

評語

Reply To cazfi

Reply To chippo

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

There should be a slight improvement to overall AI performance, but you would need to apply statistical methods to see them - variations between individual games are bigger than effects of the bug fixed. With civ2civ3 #42191 might override any improved calculation correctness, so you would need to use e.g. classic ruleset.

Actually, it might show up as AI having lower tax rate. It uses income calculated by dai_calc_data() when deciding how high tax rate it needs for a balanced budget.

2021-06-02 23:11 Updated by: cazfi

• 里程碑 Update from 2.6.5 (closed) to 2.6.6 (closed)

2021-07-09 14:45 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 負責人 Update from (無) to cazfi
• 處理結果 Update from Accepted to 修正

評語

(This comment has been deleted)

2024-10-09 14:18 Updated by: cazfi

• Summary Updated