待辦事項 #41859

alien: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there

啟用日期: 2021-03-26 10:26 最後更新: 2021-05-02 06:21

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

Seen on S3_1 autogame logs (autoalien.serv sets alien ruleset to use):

1: - 2021/03/26 00:56:10 in read_init_script_real() [../../src/server/stdinhand.c::1208]: Loading script file '/work/freeciv/fc_test/autogames/autoalien.serv'.

2: - 2021/03/26 00:56:10 in do_log_deprecation() [../../src/utility/deprecations.c::65]: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there.

Ticket History (3/8 Histories)

2021-03-26 10:26 Updated by: cazfi
  • New Ticket "alien: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there" created
2021-03-26 11:42 Updated by: cazfi
評語

This is more than a ruleset error. It seems that the engine allows no correct way. Either we have the requirement and get that warning, or we don't have the requirement and get error:

1: All action enablers for Paradrop Unit Enter must require that the actor unit doesn't have the HutFrighten unit class flag.

2021-04-22 03:38 Updated by: cazfi
評語

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs. Do we have any idea what should be done with this?

2021-04-28 11:02 Updated by: cazfi
評語

Reply To cazfi

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs. Do we have any idea what should be done with this?

Sveinung? Do you think we can have some resolution to this before S3_1-alpha1?

2021-04-28 19:24 Updated by: kvilhaugsvik
  • 負責人 Update from (無) to kvilhaugsvik
  • 處理結果 Update from to Accepted
  • 里程碑 Update from (無) to 3.1.0 (closed)
  • 元件 Update from (無) to Rulesets
評語

Reply To cazfi

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs.

Patch for alien and civ1 attached.

Do we have any idea what should be done with this?

Patch depends on #42095 that considers an obligatory hard requirement alternative fulfilled if a universal that never is there is required to be absent

2021-04-28 19:34 Updated by: cazfi
評語

Thank you. That is one obstacle less for 3.1.

2021-05-02 06:21 Updated by: kvilhaugsvik
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正
評語

Reply To cazfi

Thank you. That is one obstacle less for 3.1.

You are welcome

編輯

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登入