待辦事項 #41796

NoVeteran in effects but not in use

啟用日期: 2021-03-17 03:21 最後更新: 2023-09-02 17:35

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

Ticket History (3/12 Histories)

2021-03-17 03:21 Updated by: kvilhaugsvik
  • New Ticket "NoVeteran in effects but not in use" created
2021-03-20 04:28 Updated by: ihnatus
評語

Might be, it's a good preparation for the case they ever appear, and we should just omit such requirements when we load the ruleset?

2021-03-20 05:53 Updated by: kvilhaugsvik
評語

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

2021-03-20 06:14 Updated by: cazfi
評語

Also, we should not omit any rules from the ruleset at loading time - that would leave them out also when saving rules back from ruledit or ruleup. We even have to store some meta-rules that have any effect only at ruleset loading time.

2021-03-20 19:42 Updated by: ihnatus
評語

Reply To kvilhaugsvik

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

Just for a bit of productivity. But per Cazfi, maybe not worth the work.

2023-05-12 13:18 Updated by: cazfi
評語

Reply To kvilhaugsvik

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

See also #48028 (affects main -> 3.3+)

2023-06-26 20:56 Updated by: cazfi
  • 里程碑 Update from (無) to 3.0.9 (closed)
  • 元件 Update from (無) to Rulesets
2023-08-27 13:03 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

Reply To cazfi

See also #48028 (affects main -> 3.3+)

Thus main is not affected. Patches for S3_0 - S3_2 attached.

2023-09-02 17:35 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入