待辦事項 #41123

Counter ruleset network packet

啟用日期: 2021-01-08 16:08 最後更新: 2022-09-14 11:42

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
4

細節

Introduce a new network packet containing ruleset information about one counter. Send these packets to client when rulesets have been loaded.

Ticket History (3/21 Histories)

2021-01-08 16:08 Updated by: cazfi
  • New Ticket "Counter ruleset network packet" created
2021-11-08 14:04 Updated by: cazfi
  • Details Updated
2022-08-19 21:33 Updated by: lachu
評語

@cazfi: Can you look on my patch?

(Edited, 2022-08-19 21:34 Updated by: lachu)
2022-08-19 22:19 Updated by: cazfi
評語

Reply To lachu

@cazfi: Can you look on my patch?

Yea, I try to get closer to winter time work habits during this weekend, if not yet to full steam.

2022-08-21 14:28 Updated by: cazfi
評語

- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)
- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive
- Function headers missing for the new functions

2022-08-21 14:30 Updated by: cazfi
評語

Reply To cazfi

- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive

Sorry, I forgot the ticket reordering. So this will come in a a dependency ticket #41122

2022-09-06 06:18 Updated by: cazfi
評語

Reply To cazfi

- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)

...

- Function headers missing for the new functions

Any progress with this?

2022-09-07 21:56 Updated by: lachu
評語

Reply To cazfi

Reply To cazfi

- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)

...

- Function headers missing for the new functions

Any progress with this?

0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch(8KB)
Apply this

Aughhh..... Sory.. I miss some of your comment. I must address three problems yet.

(Edited, 2022-09-07 21:57 Updated by: lachu)
2022-09-08 01:02 Updated by: lachu
評語

Reply To cazfi

- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)

Done. I will publish patch later.

- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive

I added it into: PACKET_RULESET_CONTROL = 155; sc, lsend

- Function headers missing for the new functions

I must check, what do you mean. There is client_counter.h file. I known, it should be called client_counters.h

2022-09-08 01:16 Updated by: lachu
評語

2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached

Moved client-related function around counter and network handling into packhand.c

2022-09-08 01:20 Updated by: lachu
評語

Reply To [comment:12505:41123:63885

- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive[[

Ok. I added num_counters to control packet in other patch: 5d85fc89fdaaead8ad7bb3f6835d206bc3fd3208 . What do now?

2022-09-08 01:38 Updated by: cazfi
評語

Reply To lachu

2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached

Moved client-related function around counter and network handling into packhand.c

- client/Makefile.am still refers to those removed source files, causing build to fail in lack of them
- Space before ";" in "packet.checkpoint = pcount->checkpoint ;"
- For counter_target and counter_behavior enum definitions in fc_types.h, now part of network protocol, add the standard "/* Used in the network protocol. */" -comment

2022-09-08 23:45 Updated by: lachu
  • File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10272) is attached
2022-09-08 23:45 Updated by: lachu
  • File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10272) is deleted
2022-09-08 23:45 Updated by: lachu
評語

Reply To cazfi

Reply To lachu

2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached

Moved client-related function around counter and network handling into packhand.c

- client/Makefile.am still refers to those removed source files, causing build to fail in lack of them
- Space before ";" in "packet.checkpoint = pcount->checkpoint ;"
- For counter_target and counter_behavior enum definitions in fc_types.h, now part of network protocol, add the standard "/* Used in the network protocol. */" -comment

Done.

0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch(6KB)
In reply to: 2022-09-08 01:38 Updated by: cazfi
2022-09-09 06:32 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

Reply To lachu

Done.

Thanks

2022-09-14 11:42 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

Attachment File List

編輯

Please login to add comment to this ticket » 登入