#45687: gtk: Dead 'bg' assignment in create_tech_tree()
Open Date: 2022-09-23 06:22
Last Update: 2022-10-11 16:28
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45687
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45687
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-11 16:28 Updated by: cazfi
Comment:
I think #45831 should be resolved first.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: Gtk3.22-client
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Clang analyzer warns that create_tech_tree() assignment of 'bg = COLOR_REQTREE_BACKGROUND;' is never used. That's true as following switch sets 'bg' for each possible value of the enum.
It doesn't seem like a terrible idea to have that assignment in place, in case there's ever an illegal enum value (one that the switch won't catch), but maybe we change this regardless, to avoid clang analyzer spam about it?
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45687
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45687