#45932: New pop-unit nationality feature hard-codes behaviours that should be specified by rulesets? Open Date: 2022-10-20 03:48 Last Update: 2022-12-29 16:46 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45932 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45932 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-12-29 16:46 Updated by: cazfi Comment: Reply To cazfi Revert the patch from there Complete revert is not much of an option - we want to keep the refactoring, upon which also other things have been built. I'm for the small code change of not setting unit nationality based on this new code in S3_1. --------------------------------------------------------------------- Ticket Status: Reporter: (Anonymous) Owner: (None) Type: Support Request Status: Open Priority: 5 - Medium MileStone: 3.1.0-beta1 Component: (None) Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: This is a question which, if the answer is yes, then it qualifies as a bug in my opinion. 5f95edf546a13866a3361363136966ea08dee6ee "Build units with a nationality of the citizens spent on them" Does this hard-code on the server that making Settlers/Migrants while having dominant foreign population, FORCES a ruleset to make foreign units? If so, shouldn't this behaviour be optionally regulated by a server option? Because it would BREAK the behaviour of existing rulesets? Also this is more of a question, but I'm baffled what it does if the foreigners are enemy nationality as a result of recent conquest. Like I said, not bugs but questions! -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45932 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45932