#46273: Introduce counter-shares-index to reduce CPU/memory usage
Open Date: 2022-12-15 01:19
Last Update: 2022-12-16 04:52
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/46273
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46273
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-16 04:52 Updated by: lachu
Comment:
0001-OSDN-TICKET-46273-S-awomir-Lach-slawek-lach.art.pl.patch(10KB)
Elminates one bug causes server segfault, when there is no counters defined
Sorry I do not tested it properly. I eliminate one evident bug in my code. Code is complicated now, so I do not known if applying this patch is necessary for a while. I tested it more by now and it seems to work, but again, code is not clear, so I do not known if there is no more bugs. Somebody else must test it and read, but for that PR exist.
---------------------------------------------------------------------
Ticket Status:
Reporter: lachu
Owner: cazfi
Type: Feature Requests
Status: Open [Owner assigned]
Priority: 1 - Lowest
MileStone: (None)
Component: General
Severity: 1 - Lowest
Resolution: None
---------------------------------------------------------------------
Ticket details:
Currently, server will process each counter of the same type, but that do not make sense for some kind of counter (owned, celebrating, disorder).
This change seems to skip currently processed counter by sharing index.
It also modify iterators to check index is smaller than excepted and do not process counter if so. If index is excepted, then we increase excepted value of index and process counter. By this little modifications, each kind of counters will be processed only once. To avoid this, simply change function returns if each counter of this type should share index.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/46273
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46273