#42968: Quickfix for a bug that sometimes trade partner is not revealed when route established
Open Date: 2021-10-02 14:56
Last Update: 2021-10-02 14:56
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42968
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42968
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-10-02 14:56 Updated by: cazfi
* New Ticket "Quickfix for a bug that sometimes trade partner is not revealed when route established" created
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Related to #42967, and what was written there:
"The problem I'm debugging is that establishing foreign trade route should reveal the source city to the owner of the destination city. In the failing case owner of the destination city has before seen the tile where the source city is later established. send_city_info_at_tile() behavior causes the city not to get revealed. This then lead to client crash when trade partner was NULL there."
Overall the updates about trade partner are buggy (when trading with someone you who doesn't give you shared vision), and are likely to require lot of fixing. Meanwhile we should at least avoid the crashing cases -> quick fix in this ticket.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42968
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42968