提交: 5c6296e97818f7b74bdce7aab84dc40d0bb38dc5 - amalsyah12 (git)

firtst release

Commit MetaInfo

• 修訂: 5c6296e97818f7b74bdce7aab84dc40d0bb38dc5 (tree)
• 時間: 2018-06-08 10:02:10
• 作者: Kyotaro Horiguchi <horiguchi.kyotaro@lab....>
• Commiter: Kyotaro Horiguchi

Log Message

Fix a crash bug in case debug_query_string is NULL

pg_hint_plan believed that debug_query_string cannot be null when
parse_analyze is called, but for example in the case under
exec_describe_statement_message, it is not. We see the query string in
pstate even in the case, so use it instead in the case. Since pstate
is storing the query of the lowermost level, we should use
debug_query_string in other cases.

Change Summary

• modified: pg_hint_plan.c

差異

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -1659,6 +1659,21 @@ get_query_string(ParseState *pstate, Query *query, Query **jumblequery)
 {
 	const char *p = debug_query_string;
 
+	/*
+	 * If debug_query_string is set, it is the top level statement. But in some
+	 * cases we reach here with debug_query_string set NULL for example in the
+	 * case of DESCRIBE message handling. We may still see a candidate
+	 * top-level query in pstate in the case.
+	 */
+	if (!p)
+	{
+		/* We don't see a query string, return NULL */
+		if (!pstate->p_sourcetext)
+			return NULL;
+
+		p = pstate->p_sourcetext;
+	}
+
 	if (jumblequery != NULL)
 		*jumblequery = query;