待辦事項 #9792

Does XoopsModule class need clean up?
啟用日期: 2007-01-12 11:20 最後更新: 2007-01-14 01:25

回報者:
負責人:
(del#8225)
狀態:
關閉
元件:
(無)
里程碑:
(無)
優先權:
4
嚴重程度:
5 - 中
處理結果:
修正
檔案:

細節

Reported by Marijuana.

This item have the relation with 9759.

http://sourceforge.jp/tracker/index.php?func=detail&aid=9759&group_id=64&atid=7892

Some junk lines are in kernel/module.php. 'version' may
be a required item in xoops_version.php. Therefore,
line 214 'if' line can be removed. Also, line 89
'floatval' can be removed.


Tom_G3X said,
The method we get the version should be
Legacy_Utils::convertVersionFromModinfoToInt().

Ticket History (2/2 Histories)

2007-01-14 01:25 Updated by: (del#8225)
  • 負責人 Update from (無) to nobunobu
  • 處理結果 Update from to 修正
評語
Logged In: YES
user_id=8225

I changed a kernel/module.php source and commited along the
following lines.

In order to keep compatibility, 'version' should not be a
required parameter in xoops_version.php.
To keep compatibility, I add a logic that sets 0 to
'version', if $modversion['version'] is not set in
xoops_version.php.

In order to unify a way of process, to get version as
integer value should call
Legacy_Utils::convertVersionFromModinfoToInt()
2007-01-14 01:25 Updated by: (del#8225)
  • Ticket Close date is changed to 2007-01-14 01:25
  • 狀態 Update from 開啟 to 關閉

Attachment File List

No attachments

編輯

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登入