Much Better Handler

• 回報者: minahito
• 負責人: tom_g3x
• 類型: XOOPSCube2.1 Bugs
• 狀態: 關閉
• 元件: (無)
• 里程碑: (無)
• 優先權: 3
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 無

細節 回覆

diff -u -r1.1.2.4 handler.php
--- handler.php 7 Dec 2006 16:17:56 -0000 1.1.2.4
+++ handler.php 11 Mar 2007 21:52:56 -0000
@@ -68,7 +68,7 @@
{
$ret = array();

- $sql = "SELECT * FROM " . $this->mTable;
+ $sql = "SELECT * FROM `" . $this->mTable . '`';

if($criteria !== null && is_a($criteria,
'CriteriaElement')) {
$where = $this->_makeCriteria4sql($criteria);
@@ -79,7 +79,7 @@

$sorts = array();
foreach ($criteria->getSorts() as $sort) {
- $sorts[] = $sort['sort'] . ' ' . $sort['order'];
+ $sorts[] = '`' . $sort['sort'] . '` ' . $sort['order'];
}
if ($criteria->getSort() != '') {
$sql .= " ORDER BY " . implode(',', $sorts);
@@ -131,7 +131,7 @@
{
$ret = array();

- $sql="SELECT COUNT(*) c FROM " . $this->mTable;
+ $sql="SELECT COUNT(*) c FROM '" . $this->mTable . '`';

if($criteria !== null && is_a($criteria,
'CriteriaElement')) {
$where = $this->_makeCriteria4sql($criteria);
@@ -336,7 +336,7 @@
// criteria even if this approach is few slow.
//
$criteria =& new Criteria($this->mPrimary,
$obj->get($this->mPrimary));
- $sql = "DELETE FROM " . $this->mTable . " WHERE " .
$this->_makeCriteriaElement4sql($criteria, $obj);
+ $sql = "DELETE FROM `" . $this->mTable . "` WHERE " .
$this->_makeCriteriaElement4sql($criteria, $obj);

return $force ? $this->db->queryF($sql) :
$this->db->query($sql);
}

Ticket History (1/1 Histories)

2007-03-13 01:42 Updated by: tom_g3x

• Ticket Close date is changed to 2007-03-13 01:42
• 負責人 Update from (無) to tom_g3x
• 處理結果 Update from 無 to 修正
• 狀態 Update from 開啟 to 關閉

評語 回覆

Logged In: YES
user_id=6745

Fixed it.