待辦事項 #36273

regression test using psql and grep

啟用日期: 2016-04-22 14:15 最後更新: 2016-04-22 14:16

回報者:
負責人:
(無)
類型:
狀態:
開啟
元件:
(無)
里程碑:
(無)
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
檔案:

細節

Hi,

\! psql contrib_regression -c "/*+IndexScan(ti1 ti1_pred)*/ EXPLAIN (COSTS true) SELECT * FROM s1.ti1 WHERE c1 = 100" | grep -v "Planning time:"

I found that the regression test (e.g., ut-S.sql) tries to filter out the line containing "Planning time:" from the result of EXPLAIN command, in several places. But ISTM that this filtering is NOT necessary because EXPLAIN basically doesn't output that line (but EXPLAIN ANALYZE does, though).

Therefore, shouldn't we remove psql and grep parts from the tests like the above and just execute EXPLAIN command?

Regards,

Ticket History (3/3 Histories)

2016-04-22 14:15 Updated by: fujii_masao
  • New Ticket "regression test using psql and grep" created
2016-04-22 14:16 Updated by: fujii_masao
  • 類型 Update from 特色請求 to 修補檔案
2016-04-26 18:13 Updated by: horiguti
評語

You're right. This is added in the commit 7cd601eb6e8d0dfa9ce9757626ac2c279698a4c7, where it supported 9.4 beta 2. Since that version of PostgreSQL emitted the "Planning time" for (COSTS true), the regression was changed so but it had been changed to the current shape as of 9.4.0 release. As the result, no release version of PostgreSQL emits "Planning time" for (COSTS true) so the greps should be removed.

Attachment File List

No attachments

編輯

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登入