sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: SDL2-client
• 里程碑: 3.0.8 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節

As reported by clang analyzer, S3_1 popup_hurry_production_dialog() has assignment 'pBuf = pWindow->prev;' twice so that pBuf is not used at all in between. I also think that 'pWindow->prev' cannot change between those assignments, but have not checked carefully.

Ticket History (3/7 Histories)

2023-04-13 10:53 Updated by: cazfi

• New Ticket "sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()" created

2023-04-13 11:08 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12173) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is deleted

2023-04-13 11:09 Updated by: cazfi

• File 0033-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12174) is attached

2023-04-13 11:09 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

2023-04-22 01:13 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正